Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Nomenclature should be global #194

Closed
kujaku11 opened this issue Feb 2, 2024 · 1 comment · Fixed by #193
Closed

Channel Nomenclature should be global #194

kujaku11 opened this issue Feb 2, 2024 · 1 comment · Fixed by #193
Assignees
@kujaku11
Labels
enhancement New feature or request

Comments

@kujaku11
Copy link
Owner

kujaku11 commented Feb 2, 2024

Channel Nomenclature is found in many objects and could benefit from a global variable. Currently the default is:

{
    "hx": "hx",
    "hy": "hy",
    "hz": "hz",
    "ex": "ex",
    "ey": "ey",
}

Should move this to mt_metadata.__init__.py. That way it's not populated incorrectly in various places.
@kujaku11 kujaku11 added the enhancement New feature or request label Feb 2, 2024
@kujaku11 kujaku11 self-assigned this Feb 2, 2024
@kujaku11
Copy link
Owner Author

kujaku11 commented Feb 3, 2024

fixed in PR #193

@kujaku11 kujaku11 linked a pull request Feb 3, 2024 that will close this issue
Adjust how TF._initialize_transfer_function is setup #193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kujaku11 kujaku11

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust how TF._initialize_transfer_function is setup kujaku11/mt_metadata
1 participant
@kujaku11