Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loguru instead of builtin logging #153

Merged
merged 2 commits into from Jul 17, 2023
Merged

Use loguru instead of builtin logging #153

merged 2 commits into from Jul 17, 2023

Conversation

kujaku11
Copy link
Owner

Update code to use loguru package for easier logging, at least it seems easier and hopefully more efficient than the way I had logging setup. No longer logs to file that is up to the user to configure.
Fixes issue #150.

@kujaku11 kujaku11 added the enhancement New feature or request label Jul 17, 2023
@kujaku11 kujaku11 self-assigned this Jul 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 81.53% and project coverage change: +0.09 🎉

Comparison is base (0318dbd) 81.80% compared to head (ebe3d17) 81.90%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   81.80%   81.90%   +0.09%     
==========================================
  Files         262      261       -1     
  Lines       17595    17526      -69     
==========================================
- Hits        14394    14354      -40     
+ Misses       3201     3172      -29     
Impacted Files Coverage Δ
.../transfer_functions/io/edi/metadata/information.py 88.19% <ø> (-0.09%) ⬇️
mt_metadata/utils/list_dict.py 88.33% <ø> (-0.10%) ⬇️
setup.py 0.00% <ø> (ø)
mt_metadata/base/schema.py 42.23% <16.66%> (-0.71%) ⬇️
mt_metadata/utils/validators.py 81.12% <60.00%> (ø)
mt_metadata/timeseries/stationxml/utils.py 90.21% <66.66%> (ø)
mt_metadata/transfer_functions/io/edi/edi.py 70.97% <66.66%> (ø)
mt_metadata/base/metadata.py 75.23% <75.00%> (+1.15%) ⬆️
...meseries/stationxml/xml_inventory_mt_experiment.py 83.21% <80.00%> (ø)
mt_metadata/transfer_functions/io/zfiles/zmm.py 59.88% <83.33%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kujaku11 kujaku11 merged commit a89fb84 into main Jul 17, 2023
11 of 12 checks passed
@kujaku11 kujaku11 deleted the loguru branch July 17, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants