Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to support zfiles tests #163

Merged
merged 1 commit into from Sep 23, 2023
Merged

Minor changes to support zfiles tests #163

merged 1 commit into from Sep 23, 2023

Conversation

kkappler
Copy link
Collaborator

@kujaku11 I made some minor changes in the previous two commits that broke z file tests.
Tests now run fine with the very minor changes here.

These are related to the two things I added:

  1. Read/Write processing type from header of z file (if present)
  2. Now packing decimation dict (and passing it to TF) on z file read-in.
    PTAL

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Patch coverage: 79.06% and project coverage change: +0.45% 🎉

Comparison is base (3fabc9c) 81.86% compared to head (f602072) 82.31%.
Report is 10 commits behind head on fcs.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              fcs     #163      +/-   ##
==========================================
+ Coverage   81.86%   82.31%   +0.45%     
==========================================
  Files         269      269              
  Lines       19502    19547      +45     
==========================================
+ Hits        15966    16091     +125     
+ Misses       3536     3456      -80     
Files Changed Coverage Δ
...ata/transfer_functions/io/emtfxml/metadata/data.py 70.21% <0.00%> (ø)
.../transfer_functions/io/emtfxml/metadata/helpers.py 86.41% <0.00%> (-1.09%) ⬇️
tests/tf/io/zmm/test_tf_read_zmm.py 98.78% <ø> (ø)
tests/tf/io/zmm/test_tf_read_zss.py 98.07% <ø> (ø)
..._metadata/transfer_functions/io/emtfxml/emtfxml.py 65.63% <10.00%> (-0.27%) ⬇️
mt_metadata/transfer_functions/core.py 68.28% <50.00%> (+0.15%) ⬆️
mt_metadata/transfer_functions/io/zfiles/zmm.py 66.87% <66.66%> (+0.13%) ⬆️
...ions/processing/fourier_coefficients/decimation.py 73.00% <81.25%> (+28.51%) ⬆️
mt_metadata/utils/mttime.py 83.11% <100.00%> (+0.66%) ⬆️
tests/test_mttime.py 98.56% <100.00%> (+0.02%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkappler kkappler removed the request for review from kujaku11 September 23, 2023 22:39
@kkappler kkappler merged commit 3f941d0 into fcs Sep 23, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants