Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scipy filters to xarray #139

Merged
merged 7 commits into from Mar 29, 2023
Merged

Add Scipy filters to xarray #139

merged 7 commits into from Mar 29, 2023

Conversation

kujaku11
Copy link
Owner

@kujaku11 kujaku11 commented Mar 29, 2023

Add ability to access filter methods directly from an xarray.DataArray or xarray.Dataset, this has been done in a package called xr-scipy, which doesn't seem to be supported much recently. So here we are going to update some of the filter methods and incorporate them within MTH5.

  • Add decimation
  • Add detrend
  • Add zero mean
  • Add lowpass
  • Add highpass
  • Add bandpass
  • Add windowing?
  • Update tests
  • Update documentation

@kujaku11 kujaku11 self-assigned this Mar 29, 2023
@kujaku11 kujaku11 added enhancement New feature or request Filters Functionality dealing with how filters are used, applied, and described labels Mar 29, 2023
@kujaku11 kujaku11 linked an issue Mar 29, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 63.87% and project coverage change: +0.04 🎉

Comparison is base (4281535) 58.71% compared to head (dbeca1b) 58.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   58.71%   58.76%   +0.04%     
==========================================
  Files         118      120       +2     
  Lines       12292    12500     +208     
==========================================
+ Hits         7217     7345     +128     
- Misses       5075     5155      +80     
Impacted Files Coverage Δ
mth5/io/collection.py 30.15% <0.00%> (-0.49%) ⬇️
mth5/io/phoenix/readers/header.py 33.60% <0.00%> (-0.10%) ⬇️
tests/io/lemi/test_lemi_collection.py 44.89% <0.00%> (-0.94%) ⬇️
tests/version_1/test_make_mth5_geomag.py 22.41% <0.00%> (ø)
tests/version_2/test_make_mth5_geomag.py 22.22% <0.00%> (ø)
mth5/io/usgs_ascii/header.py 34.21% <12.50%> (-0.46%) ⬇️
tests/io/zen/test_z3d.py 42.51% <28.57%> (ø)
mth5/timeseries/scipy_filters.py 54.92% <54.92%> (ø)
mth5/timeseries/channel_ts.py 82.06% <60.00%> (-0.63%) ⬇️
mth5/timeseries/run_ts.py 73.69% <60.00%> (-0.60%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kujaku11 kujaku11 merged commit d7b7a90 into master Mar 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Filters Functionality dealing with how filters are used, applied, and described
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChannelTS and RunTS resample is incorrect
2 participants