New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Channels in RunTS #141
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 58.76% 59.50% +0.74%
==========================================
Files 120 122 +2
Lines 12500 12728 +228
==========================================
+ Hits 7345 7574 +229
+ Misses 5155 5154 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…to remove_response
This PR addresses #140 when input channels are slightly off from each other, one maybe have a few more samples.
Update
RunTS
to locate the differences, estimate the earliest start time, the latest end time and reindex each channel onto a common time index. Xarray tools do not seem to work when the time indexes are slightly off from one another when combining into a dataset. It combines any unique time index and places a NaN on any sample that doesn't have that same time index (usingalign
,merge
). If you try toresample/reindex/interpolate
a combined dataset it gets FUBARed with misplaced NaN's. Therefore, we need to reindex each channel separately before combining into a dataset.