Clients

[kujaku11]

• factor out different clients in MakeMTH5:
  • FDSN
  • Science Base
  • AUS
• Update tests
• Update documentation

[kujaku11]

@timronan, @kkappler I factored out FDSN into its own module and then added a function in MakeMTH5.from_fdsn_client.

The new use would be:

make_mth5 = MakeMTH5(mth5_version="0.2.0")
make_mth5.save_path = "/path/to/new/mth5/file"
make_mth5.interact = True

mth5_object = make_mth5.from_fdsn_client(request_df)

do you guys have any thoughts on this architecture?

For other clients we would just add a method from_new_client and that method would call NewClient.make_mth5(**kwargs)

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@5cab168). Click here to learn what that means.
Patch coverage: 64.18% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage          ?   58.71%           
=========================================
  Files             ?      118           
  Lines             ?    12292           
  Branches          ?        0           
=========================================
  Hits              ?     7217           
  Misses            ?     5075           
  Partials          ?        0           

Impacted Files	Coverage Δ
mth5/io/collection.py	30.64% <0.00%> (ø)
mth5/io/zen/z3d_collection.py	17.18% <0.00%> (ø)
mth5/io/zen/zen.py	19.83% <0.00%> (ø)
tests/version_1/test_make_mth5.py	23.01% <7.31%> (ø)
tests/version_2/test_make_mth5.py	21.05% <8.10%> (ø)
mth5/clients/fdsn.py	8.15% <8.15%> (ø)
tests/version_2/test_make_mth5_geomag.py	22.22% <22.22%> (ø)
tests/version_1/test_make_mth5_geomag.py	22.41% <22.41%> (ø)
mth5/timeseries/channel_ts.py	82.69% <75.29%> (ø)
mth5/timeseries/run_ts.py	74.28% <77.02%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.