Using requestAnimationFrame instead of setTimeout to ensure that the … … #2

kuldeepkeshwar · 2017-09-11T03:52:34Z

Thanks for contributing to react-virtualized!

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Run tests locally (npm test) to ensure that your change did not break linting or functionality.
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

…debounce scroll callback will be executed in the expected time.

…mationFrame. setTimout with zero delay was used in Masonry test to wait tasks of requestAnimationFrame finish before assert the result.

…debounce scroll callback will be executed in the expected time.

…mationFrame. setTimout with zero delay was used in Masonry test to wait tasks of requestAnimationFrame finish before assert the result.

…irtualized

…unt.

… requestAnimationFrame This update also replaces setTimeout/clearTimeout in the WindowScroller component with the requestAnimationFrame-based timeout function.

…nTimeout.

…browsers (eg IE9)

add onWheel prop

Document ArrowKeyStepper's disabled property

…easier to understand. - The underlying logic is untouched. - Adds intermediate variables so it's clear as to what the logic is doing.

Make CellSizeAndPositionManager.getTotalSize() more explicit so it's easier to understand.

…ault cellMeasurerCache.clear() add 0 as default columnIndex

Wizard demo: Add a key prop to CodeMirror that increments on state change

Clear row/column counts with CMC.ClearAll

gnbaron and others added 30 commits July 17, 2017 14:57

Using requestAnimationFrame instead of setTimeout to ensure that the …

c20bf15

…debounce scroll callback will be executed in the expected time.

Fixing tests after start to using requestAnimationFrame and cancelAni…

d534319

…mationFrame. setTimout with zero delay was used in Masonry test to wait tasks of requestAnimationFrame finish before assert the result.

Using requestAnimationFrame instead of setTimeout to ensure that the …

aa4bcfd

…debounce scroll callback will be executed in the expected time.

Fixing tests after start to using requestAnimationFrame and cancelAni…

a706712

…mationFrame. setTimout with zero delay was used in Masonry test to wait tasks of requestAnimationFrame finish before assert the result.

Merge branch 'master' of https://github.com/guilhermefloriani/react-v…

14678f8

…irtualized

Avoid use a chain lookup

089af39

Avoid allocating one function for each scroll ended callback.

3264b83

merge

c47959f

Use cancelAnimationFrame instead of clearTimeOut on componentWillUnmo…

d782956

…unt.

Merge branch 'master' of https://github.com/bvaughn/react-virtualized

a67e150

Encapsulates scroll end debouncing into a timeout function relying on…

477ac94

… requestAnimationFrame This update also replaces setTimeout/clearTimeout in the WindowScroller component with the requestAnimationFrame-based timeout function.

Fixing pretty warnings and use just named imports for requestAnimatio…

cf2f8d0

…nTimeout.

Merge branch 'master' of https://github.com/bvaughn/react-virtualized

c2e1d93

add onWheel prop

86f1d57

Expose unfiltered rest prop for grid

437bd5f

Merge remote-tracking branch 'guilhermefloriani/master'

741b156

Newly-added raf-based timeouts now fall back to setTimeout for older …

f3beee0

…browsers (eg IE9)

Merge pull request #778 from implausible/feature/enable-on-wheel

9f3e81d

add onWheel prop

Lint fixes

c495dce

Added key to CodeMirror that increments on state change

0e2666b

State assignment not needed on setState()

1f61ba9

cellMeasurerCache.clear() add 0 as default columnIndex

7d42d68

Document ArrowKeyStepper's disabled property

c10bd00

Merge pull request #788 from thevtm/master

a961a0c

Document ArrowKeyStepper's disabled property

Make CellSizeAndPositionManager.getTotalSize() more explicit so it's …

8c092e4

…easier to understand. - The underlying logic is untouched. - Adds intermediate variables so it's clear as to what the logic is doing.

Formatting nits

4d6555e

Merge pull request #792 from ayc92/clarify_get_total_size_return_val

b7db75d

Make CellSizeAndPositionManager.getTotalSize() more explicit so it's easier to understand.

Merge pull request #785 from tihuan/cell-measurer-cache-clear-add-def…

31af01f

…ault cellMeasurerCache.clear() add 0 as default columnIndex

Added TODO

162214f

Merge pull request #784 from cvpcasada/fix-wizard-not-working

6e58496

Wizard demo: Add a key prop to CodeMirror that increments on state change

bvaughn and others added 5 commits August 30, 2017 10:42

Ran prettier

e93b3dc

Clear row/column counts with CMC.ClearAll

05fdecf

Update CONTRIBUTING.md to mention Yarn

ad6837f

Add test for clearing row/column counts

8eac863

Merge pull request #796 from tcosentino/clear-all-counts

6cf3e44

Clear row/column counts with CMC.ClearAll

kuldeepkeshwar merged commit 7a39fb0 into kuldeepkeshwar:master Sep 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using requestAnimationFrame instead of setTimeout to ensure that the … … #2

Using requestAnimationFrame instead of setTimeout to ensure that the … … #2

kuldeepkeshwar commented Sep 11, 2017

Using requestAnimationFrame instead of setTimeout to ensure that the … … #2

Using requestAnimationFrame instead of setTimeout to ensure that the … … #2

Conversation

kuldeepkeshwar commented Sep 11, 2017