Display is incorrect after auto refresh

[ghost]

I've been testing this plugin with patch #2024 and there seems to be a problem when dragging the time bar on the gantt chart.

I have a number of inter-related issues and when I try to change the start or due date using the date picker boxes, then Redmine correctly recalculates related issues and auto refreshes the display fine.

However, when I try to drag the time bar on the gantt chart it still recalculates related issues correctly, but it then displays everything incorrectly after the auto refresh.

After discussing this with the author of #2024 he thinks it is to do with the plugin not using the correct zoom level when it refreshes the display. This is why is seems to throw everything out until you manually refresh the screen.

As I said, it saves everything correctly, it just doesn't display it correctly after the auto refresh.

Thanks,

Chris

[kulesa]

Hi Chris,

that's interesting, because on my environment I see quite the opposite behaviour: when I drag an issue it displays everything correctly. When I use a date picker, then the chart displays correctly only on max zoom level. On other zoom levels after refresh issues displayed more to the right than they should be. It could be we are using different versions of #2024. I use this one (the latest available): http://www.redmine.org/attachments/5513/gantt_edit_2_v1-1-1.patch

I quickly checked sources of #2024 and found that function observe_date_field passes zoom*4 and function issue_moved just plain zoom, which causes different display after update by drag-n-drop and update via a date picker. Apparently this should be easy to fix for the author of patch.

I also checked once again that my plugin doesn't change this functionality of #2024 and that even without my plugin #2024 works the same way. So I really think this issue should be addressed to the author of patch.

[ghost]

I'm now using a newer version of the #2024 patch (v5 - see attached),
which corrects a few other bugs.

When I remove the better gantt chart plugin and just use the patch, both
changing the date picker and dragging the bar seems to work fine and the
display refreshes correctly.

However, when I re-add the better gantt chart plugin and restart the
application then it doesn't display correctly after dragging the gantt bar.

I really need to get them both working if possible as your plugin seems
to handle the related issues much better, but the patch obviously allows
editing of the gantt chart on the fly. As I mentioned previously, I
would love to see these 2 combined into one plugin.

Please let me know if you have any further questions.

Chris

On 05/04/11 13:38, kulesa wrote:

Hi Chris,

that's interesting, because on my environment I see quite the opposite behaviour: when I drag an issue it displays everything correctly. When I use a date picker, then the chart displays correctly only on max zoom level. On other zoom levels after refresh issues displayed more to the right than they should be. It could be we are using different versions of #2024. I use this one (the latest available): http://www.redmine.org/attachments/5513/gantt_edit_2_v1-1-1.patch

I quickly checked sources of #2024 and found that function observe_date_field passes zoom*4 and function issue_moved just plain zoom, which causes different display after update by drag-n-drop and update via a date picker. Apparently this should be easy to fix for the author of patch.

I also checked once again that my plugin doesn't change this functionality of #2024 and that even without my plugin #2024 works the same way. So I really think this issue should be addressed to the author of patch.

[kulesa]

Can you send the new version of the patch to my email kulesa@gmail.com ? It doesn't allow attach files to GitHub issues.

[ghost]

I've just sent it now.

On 05/04/11 15:24, kulesa wrote:

Can you send the new version of the patch to my email kulesa@gmail.com ? It doesn't allow attach files to GitHub issues.

[kulesa]

Fixed in patch2024 branch for gantt_edit_5_v1-1-1.patch.

[ghost]

I've just tested the new version and can confirm it works fine with v5
of the #2024 patch.

On 06/04/11 08:04, kulesa wrote:

Fixed in patch2024 branch for gantt_edit_5_v1-1-1.patch.