Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute convolution in NCHW if the suggested mem format is NHWC but the actual mem layout is NCHW #303

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
23d334b
Add back support for PYTORCH_TEST_WITH_MPS (#66)
DenisVieriu97 Jul 19, 2022
12085cf
Enable MPS CI runners (#252)
DenisVieriu97 Jan 24, 2023
e8f89df
Use DISTRIBUTED=1 for MPS CI runners (#292)
DenisVieriu97 Feb 4, 2023
85cdb98
Update the test mps.
kulinseth Feb 14, 2023
66951a0
Remove torch._six from test_mps (#326)
razarmehr Feb 14, 2023
5ada241
Remove unnecessary CI files (#327)
DenisVieriu97 Feb 14, 2023
bf8eba9
Enable test modules on MPS and CI runners (#305) (#324)
DenisVieriu97 Feb 14, 2023
2f336a4
[CHERRY-PICK] Block uint8 data type for unary and binary ops on macOS…
DenisVieriu97 Feb 14, 2023
108cdc0
Fix test_zero_grad() (#330)
razarmehr Feb 15, 2023
8de3315
Convert output back to ChannelsLast if needed (#325)
razarmehr Feb 15, 2023
051bc9c
Fix bilinear backward pass (#331)
DenisVieriu97 Feb 15, 2023
1b09ea2
Update macOS 12 blocklist (#323)
Ronian526 Feb 15, 2023
8c7df6f
[MPS] Fixes for LSTM. (#319)
jhavukainen Feb 15, 2023
d42f74f
Fix nn.functional.conv_transpose2d grad (#312) (#329)
DenisVieriu97 Feb 15, 2023
2856203
Fix the crash in elu_backward() (#333)
razarmehr Feb 15, 2023
18797b0
Fix nn.functional.embedding grad (#335)
Ronian526 Feb 15, 2023
cf06ac5
Fix prelu backward (#334)
DenisVieriu97 Feb 15, 2023
c65b823
Reduction cast f16 to f32 only on macOS 12 (#332)
Ronian526 Feb 15, 2023
73f7068
Remove periodic file (running between PRs) (#336)
DenisVieriu97 Feb 16, 2023
1c8f126
Fix upsample for NHWC output (#337)
DenisVieriu97 Feb 16, 2023
42be72a
[DOWNSTREAM] Fix build failure on x86 runners (#338)
DenisVieriu97 Feb 16, 2023
6ace5f9
Fix trace op (#340)
Ronian526 Feb 17, 2023
c9b8ab7
Update random result list (#339)
Ronian526 Feb 17, 2023
d3e414e
Fix convolution crash in backward with weights; remove unnecessary co…
DenisVieriu97 Feb 17, 2023
be8817b
Fix copy_cast_mps() on tensors with storage offset (#343)
razarmehr Feb 17, 2023
8e37116
Enable int8 in TestConsistency (#347)
DenisVieriu97 Feb 18, 2023
c30946a
Convolution cleanup (#346)
DenisVieriu97 Feb 21, 2023
b520970
Dev/skotapati/copy broadcasting (#350)
skotapati Feb 21, 2023
0473fe8
Execute convolution in NCHW if the suggested mem format is NHWC but t…
DenisVieriu97 Feb 9, 2023
9a5b002
Fix build failure
DenisVieriu97 Feb 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/pytorch/macos-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cross_compile_arm64() {
# Cross compilation for arm64
# Explicitly set USE_DISTRIBUTED=0 to align with the default build config on mac. This also serves as the sole CI config that tests
# that building with USE_DISTRIBUTED=0 works at all. See https://github.com/pytorch/pytorch/issues/86448
USE_DISTRIBUTED=0 CMAKE_OSX_ARCHITECTURES=arm64 MACOSX_DEPLOYMENT_TARGET=11.0 USE_MKLDNN=OFF USE_QNNPACK=OFF WERROR=1 BUILD_TEST=OFF USE_PYTORCH_METAL=1 python setup.py bdist_wheel
USE_DISTRIBUTED=1 CMAKE_OSX_ARCHITECTURES=arm64 MACOSX_DEPLOYMENT_TARGET=11.0 USE_OPENMP=OFF USE_MKLDNN=OFF USE_QNNPACK=OFF WERROR=1 BUILD_TEST=OFF USE_PYTORCH_METAL=1 python setup.py bdist_wheel
}

compile_x86_64() {
Expand Down
29 changes: 0 additions & 29 deletions .github/auto_request_review.yml

This file was deleted.

5 changes: 3 additions & 2 deletions .github/workflows/_mac-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ on:

jobs:
build:
# Don't run on forked repos.
if: github.repository_owner == 'pytorch'
# # Don't run on forked repos.
# if: github.repository_owner == 'pytorch'
runs-on: ${{ inputs.runner-type }}
env:
# For sccache access (only on non-forked PRs)
Expand Down Expand Up @@ -106,6 +106,7 @@ jobs:
environment-file: ${{ inputs.environment-file }}

- name: Install macOS homebrew dependencies
if: ${{ runner.arch == 'X64' }}
run: |
# Install dependencies
brew install libomp
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/_mac-test-mps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,20 @@ jobs:
set -ex
${CONDA_RUN} python3 test/run_test.py --mps --verbose

- name: Run MPS Test Modules
id: test_2
env:
ENV_NAME: conda-test-env-${{ github.run_id }}
shell: arch -arch arm64 bash {0}
# During bring up of test_modules don't show this as an error.
continue-on-error: true
run: |
# shellcheck disable=SC1090
set -ex
# TODO(https://github.com/pytorch/pytorch/issues/79293)

${CONDA_RUN} python3 test/test_modules.py -k mps --verbose

- name: Print remaining test logs
shell: bash
if: always()
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/_mac-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
echo "monitor-script-pid=${!}" >> "${GITHUB_OUTPUT}"

- name: Install macOS homebrew dependencies
if: ${{ runner.arch == 'X64' }}
run: |
# Install dependencies
brew install libomp
Expand Down Expand Up @@ -182,6 +183,12 @@ jobs:
run: |
cat test/**/*.log || true

- name: Print remaining test logs
shell: bash
if: always()
run: |
cat test/**/*.log || true

- name: Get workflow job id
id: get-job-id
uses: ./.github/actions/get-workflow-job-id
Expand Down
22 changes: 0 additions & 22 deletions .github/workflows/auto_request_review.yml

This file was deleted.

44 changes: 0 additions & 44 deletions .github/workflows/check-labels.yml

This file was deleted.