Reduction cast f16 to f32 only on macOS 12 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ronian526
commented
Feb 15, 2023
Ronian526
commented
- unblock rdiv float16
- unblock rdiv float16
Ronian526
requested review from
skotapati,
razarmehr,
ssaladis and
DenisVieriu97
DenisVieriu97
approved these changes
Feb 15, 2023
kulinseth
added a commit
that referenced
this pull request
Feb 28, 2023
Remove torch._six from test_mps (#326) Fix test_zero_grad() (#330) Fix bilinear backward pass (#331) * Fix bilinear backward pass * Remove comment Update macOS 12 blocklist (#323) * Update macOS 12 blocklist - move sum, masked.var, mul to low precision list - unblock them from running * - mark __rdiv__ failures as accumulate error exceeds atol/rtol Fix nn.functional.embedding grad (#335) - casting the input tensor to float32 and cast back the output tensor - unblock the test Fix prelu backward (#334) Reduction cast f16 to f32 only on macOS 12 (#332) - unblock rdiv float16 Fix trace op (#340) - give warnings of converting int64 for reduction ops - use cast tensor for reduction sum on trace - unblock trace from running Update random result list (#339) * - move nn.functional.feature_alpha_dropoutwith_train, normalnumber_mean, new_empty_strided to expected failures * - update new_empty_strided --------- Co-authored-by: Kulin Seth <kulin_seth@apple.com> Enable int8 in TestConsistency (#347) Dev/skotapati/copy broadcasting (#350) * Handle broadcasting by expanding src tensor in Copy.mm * Unblock linalg_matrix_power * Improved formatting Add the functionality to dump MPS ops. 1. DUMP_MPS_OPS to use LoggingTensor to dump out the ATen ops. 2. Skip running the EXPECTTEST list, as some tests are still seg-faulting Fix lintrunner errors (#353) * Fix lintrunner errors * - move normal_in_place to random result list Fixed the test_mps. Test mps is updated.
DenisVieriu97
pushed a commit
that referenced
this pull request
Feb 28, 2023
Remove torch._six from test_mps (#326) Fix test_zero_grad() (#330) Fix bilinear backward pass (#331) * Fix bilinear backward pass * Remove comment Update macOS 12 blocklist (#323) * Update macOS 12 blocklist - move sum, masked.var, mul to low precision list - unblock them from running * - mark __rdiv__ failures as accumulate error exceeds atol/rtol Fix nn.functional.embedding grad (#335) - casting the input tensor to float32 and cast back the output tensor - unblock the test Fix prelu backward (#334) Reduction cast f16 to f32 only on macOS 12 (#332) - unblock rdiv float16 Fix trace op (#340) - give warnings of converting int64 for reduction ops - use cast tensor for reduction sum on trace - unblock trace from running Update random result list (#339) * - move nn.functional.feature_alpha_dropoutwith_train, normalnumber_mean, new_empty_strided to expected failures * - update new_empty_strided --------- Co-authored-by: Kulin Seth <kulin_seth@apple.com> Enable int8 in TestConsistency (#347) Dev/skotapati/copy broadcasting (#350) * Handle broadcasting by expanding src tensor in Copy.mm * Unblock linalg_matrix_power * Improved formatting Add the functionality to dump MPS ops. 1. DUMP_MPS_OPS to use LoggingTensor to dump out the ATen ops. 2. Skip running the EXPECTTEST list, as some tests are still seg-faulting Fix lintrunner errors (#353) * Fix lintrunner errors * - move normal_in_place to random result list Fixed the test_mps.
skotapati
pushed a commit
that referenced
this pull request
Apr 7, 2023
Remove torch._six from test_mps (#326) Fix test_zero_grad() (#330) Fix bilinear backward pass (#331) * Fix bilinear backward pass * Remove comment Update macOS 12 blocklist (#323) * Update macOS 12 blocklist - move sum, masked.var, mul to low precision list - unblock them from running * - mark __rdiv__ failures as accumulate error exceeds atol/rtol Fix nn.functional.embedding grad (#335) - casting the input tensor to float32 and cast back the output tensor - unblock the test Fix prelu backward (#334) Reduction cast f16 to f32 only on macOS 12 (#332) - unblock rdiv float16 Fix trace op (#340) - give warnings of converting int64 for reduction ops - use cast tensor for reduction sum on trace - unblock trace from running Update random result list (#339) * - move nn.functional.feature_alpha_dropoutwith_train, normalnumber_mean, new_empty_strided to expected failures * - update new_empty_strided --------- Co-authored-by: Kulin Seth <kulin_seth@apple.com> Enable int8 in TestConsistency (#347) Dev/skotapati/copy broadcasting (#350) * Handle broadcasting by expanding src tensor in Copy.mm * Unblock linalg_matrix_power * Improved formatting Add the functionality to dump MPS ops. 1. DUMP_MPS_OPS to use LoggingTensor to dump out the ATen ops. 2. Skip running the EXPECTTEST list, as some tests are still seg-faulting Fix lintrunner errors (#353) * Fix lintrunner errors * - move normal_in_place to random result list Fixed the test_mps. Test mps is updated.
jhavukainen
pushed a commit
that referenced
this pull request
Mar 15, 2024
Remove torch._six from test_mps (#326) Fix test_zero_grad() (#330) Fix bilinear backward pass (#331) * Fix bilinear backward pass * Remove comment Update macOS 12 blocklist (#323) * Update macOS 12 blocklist - move sum, masked.var, mul to low precision list - unblock them from running * - mark __rdiv__ failures as accumulate error exceeds atol/rtol Fix nn.functional.embedding grad (#335) - casting the input tensor to float32 and cast back the output tensor - unblock the test Fix prelu backward (#334) Reduction cast f16 to f32 only on macOS 12 (#332) - unblock rdiv float16 Fix trace op (#340) - give warnings of converting int64 for reduction ops - use cast tensor for reduction sum on trace - unblock trace from running Update random result list (#339) * - move nn.functional.feature_alpha_dropoutwith_train, normalnumber_mean, new_empty_strided to expected failures * - update new_empty_strided --------- Co-authored-by: Kulin Seth <kulin_seth@apple.com> Enable int8 in TestConsistency (#347) Dev/skotapati/copy broadcasting (#350) * Handle broadcasting by expanding src tensor in Copy.mm * Unblock linalg_matrix_power * Improved formatting Add the functionality to dump MPS ops. 1. DUMP_MPS_OPS to use LoggingTensor to dump out the ATen ops. 2. Skip running the EXPECTTEST list, as some tests are still seg-faulting Fix lintrunner errors (#353) * Fix lintrunner errors * - move normal_in_place to random result list Fixed the test_mps. Test mps is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.