Fix convolution crash in backward with weights; remove unnecessary contiguous calls #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisVieriu97
requested review from
kulinseth,
skotapati,
razarmehr,
Ronian526,
ssaladis and
shuhand0
DenisVieriu97
force-pushed
the
dev/denis/fix_conv_crash
branch
from
e44393b
to
69d2373
Compare
|
Looks good to me. |
kulinseth
approved these changes
Feb 17, 2023
DenisVieriu97
added a commit
that referenced
this pull request
Feb 17, 2023
…ntiguous calls (#341) * Fix convolution crash; remove unnecessary contiguous calls * Fix lintrunner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.