Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squeeze last dimensions if possible for 5D (or bigger) reductions #408

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Squeeze last dimensions if possible for 5D (or bigger) reductions #408

merged 3 commits into from
Apr 3, 2023

Conversation

DenisVieriu97
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 commented Apr 3, 2023 •
edited

Summary of changes:

  • Reduction ops optimization - squeeze all dimensions after 4th dim if they are all 1
  • Disable type inference only for 1D unary ops

razarmehr
razarmehr approved these changes Apr 3, 2023
View reviewed changes
Copy link

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kulinseth kulinseth merged commit 3353590 into master Apr 3, 2023
skotapati pushed a commit that referenced this pull request Apr 6, 2023
@DenisVieriu97 @skotapati
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
d82aed0 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
skotapati pushed a commit that referenced this pull request Apr 7, 2023
@DenisVieriu97 @skotapati
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
e600aab 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
skotapati pushed a commit that referenced this pull request Apr 11, 2023
@DenisVieriu97 @skotapati
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
8ec4ed8 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
DenisVieriu97 added a commit that referenced this pull request Apr 24, 2023
@DenisVieriu97
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
ad4a8cd 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
@DenisVieriu97 DenisVieriu97 added Upstreamed Change has been upstreamed to PyTorch master and removed DV: In Progress labels Jun 16, 2023
jhavukainen pushed a commit that referenced this pull request Mar 15, 2024
@DenisVieriu97 @jhavukainen
Squeeze last dimensions if possible for 5D (or bigger) reductions (#408)
d377fca 
* Squeeze last dimensions if possible for 5D (or bigger) reductions

* Remove unnecessary code

* Disable type infernce only for 1D tensors in unary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razarmehr razarmehr razarmehr approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@skotapati skotapati Awaiting requested review from skotapati

@Ronian526 Ronian526 Awaiting requested review from Ronian526

@ssaladis ssaladis Awaiting requested review from ssaladis

@shuhand0 shuhand0 Awaiting requested review from shuhand0

Assignees
No one assigned
Labels
Upstreamed Change has been upstreamed to PyTorch master
Projects
None yet
Milestone
No milestone
3 participants
@DenisVieriu97 @razarmehr @kulinseth