Handle transposes in second batch of matrices in bmm #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisVieriu97
requested review from
kulinseth,
skotapati,
razarmehr,
Ronian526 and
ssaladis
kulinseth
approved these changes
Jun 14, 2023
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
jhavukainen
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add transpose in bmm * Handle transposes in second batch of matrices in bmm * Fix comment * Fix formatting * Fix build failure * Fix test failures
jhavukainen
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add transpose in bmm * Handle transposes in second batch of matrices in bmm * Fix comment * Fix formatting * Fix build failure * Fix test failures
jhavukainen
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Add transpose in bmm * Handle transposes in second batch of matrices in bmm * Fix comment * Fix formatting * Fix build failure * Fix test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle transposes in second batch of matrices in
bmmop.Improves
bmmop perf if second matrix is transposed (row by row matrix multiplication is much faster compared to row by column since all memory is contiguous / no strided accesses are performed).