Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract mocked function in a different package #1048

Closed
eloiqs opened this issue Mar 30, 2019 · 10 comments
Closed

Extract mocked function in a different package #1048

eloiqs opened this issue Mar 30, 2019 · 10 comments

Comments

@eloiqs
Copy link

eloiqs commented Mar 30, 2019

Hello 馃憢

I have been using babel to compile my typescript projects more and more lately, and the only reason why I am still installing ts-jest is because of the utils/mocked function.

Would you consider extracting this util into its own package?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Apr 12, 2019

Maybe it can be exported under ts-jest/utils ? PR is welcome :)

cc @GeeWee @kulshekhar

@GeeWee
Copy link
Collaborator

GeeWee commented Apr 12, 2019

I think it's an excellent idea to either export it separately or extract it to its own package. PR's very welcome (or links to the new package, which we will then add to the docs.)

@dylang
Copy link

dylang commented Apr 12, 2019

Would it be worth proposing to the Jest team to add it to the core package, especially now that Jest is written in TypeScript, or to https://github.com/jest-community?

@kulshekhar
Copy link
Owner

might be worth a shot

@ahnpnl
Copy link
Collaborator

ahnpnl commented Apr 12, 2019

cc @thymikee do you think this can be in jest repo ?

@thymikee
Copy link
Contributor

@SimenB what do you think? The question is whether we should include these utils in Jest core: https://github.com/kulshekhar/ts-jest/blob/master/src/util/testing.ts

Personally I'm fine with sticking those to jest-mock and make them available through type exports.

@SimenB
Copy link
Contributor

SimenB commented Apr 12, 2019

Yeah, works for me! Looks useful

@ahnpnl
Copy link
Collaborator

ahnpnl commented Feb 6, 2020

@thymikee @SimenB I guess I will close this issue as jest will take care of it ?

@thymikee
Copy link
Contributor

thymikee commented Feb 6, 2020

@ahnpnl let's create an issue for this in Jest first, shall we?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 18, 2020

Close as Feature Request was created for Jest

@ahnpnl ahnpnl closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants