Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): set default outDir when allowJs is true and no outDir in tsconfig #1502

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 4, 2020

Summary

Bring back changes in #1472 , close #1500

Test plan

  • Added unit tests and e2e tests

  • Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 4, 2020 09:28
@ahnpnl ahnpnl changed the title fix(config): set default outDir when allowJs is true and no outDir fix(config): set default outDir when allowJs is true and no outDir in tsconfig Apr 4, 2020
@ahnpnl ahnpnl merged commit 1a287ad into kulshekhar:master Apr 4, 2020
@ahnpnl ahnpnl deleted the allow-js-fix branch April 4, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[25.3.1]: "Emit skipped" Error
2 participants