Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept tsconfig alias to tsConfig #1564

Closed
jednano opened this issue Apr 24, 2020 · 2 comments 路 Fixed by #1565
Closed

Accept tsconfig alias to tsConfig #1564

jednano opened this issue Apr 24, 2020 · 2 comments 路 Fixed by #1565
Labels
馃殌 Feature Request new suggested feature

Comments

@jednano
Copy link
Contributor

jednano commented Apr 24, 2020

馃殌 Feature Proposal

Accept tsconfig (all lowercase) as an alias to tsConfig option.

Motivation

tsconfig.json is almost always referred to in the lowercase version, which makes it super simple to overlook that this package requires an uppercase C as tsConfig (a mistake that cost me some unnecessary time today).

Example

Here is the current implementation:

const { tsConfig: tsConfigOpt } = options

I suggest we simply change this to:

const tsConfigOpt = options.tsConfig ?? options.tsconfig ?? true;

This way, you can also remove tsConfigOpt == null from the following "if" statement.

@jednano jednano added the 馃殌 Feature Request new suggested feature label Apr 24, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented Apr 24, 2020

PR is welcome 馃榾

@jednano
Copy link
Contributor Author

jednano commented Apr 24, 2020

@ahnpnl done, please see #1565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃殌 Feature Request new suggested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants