Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcov html coverage report - looking for bad file paths #207

Closed
bcruddy opened this issue May 10, 2017 · 13 comments
Closed

lcov html coverage report - looking for bad file paths #207

bcruddy opened this issue May 10, 2017 · 13 comments

Comments

@bcruddy
Copy link
Contributor

bcruddy commented May 10, 2017

Environment: node 6.10.2, yarn 0.23.3, jest 20.0.0, ts-jest 20.0.0, react 15.5.4, typescript 2.3.0

I know with jest 20 and ts-jest 20 that jest itself is responsible for coverage but I want to verify here before opening an issue with them directly.

  • Issue

lcov html coverage report is having trouble reading/parsing source files:

image

  • Expected behavior

Read/parse source files correctly

  • Link to a minimal repo that reproduces this issue

Will set up if this is not a known issue and it's a ts-jest issue
https://github.com/bcruddy/tsjest-lcov-min

  • Optional (but highly recommended) - Configure Travis (or your favorite system) with the minimal repo

Setting up travis would be useless here as it's an issue with a build artifact and not anything wrong with the build itself.

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

It is correctly showing that the file is 100% covered here:

image

@kulshekhar
Copy link
Owner

@bcruddy can you try with 20.0.2

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

@kulshekhar installing now

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

@kulshekhar no change for ts-jest at 20.0.2 and 20.0.0 is the most recent version for both jest and jest-cli

@kulshekhar
Copy link
Owner

I meant ts-jest 20,0,2

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

Yeah I just edited my comment to make that more clear, sorry about that

@kulshekhar
Copy link
Owner

That's weird. Can you create a minimal repo that reproduces this?

@kulshekhar
Copy link
Owner

oh, did you use --no-cache after updating?

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

Yes I did. I'll put together a repo shortly

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

@kulshekhar here you go https://github.com/bcruddy/tsjest-lcov-min. I left the coverage in version control so you can see what I'm seeing.

@kulshekhar
Copy link
Owner

@bcruddy 20.0.3 has been published. It should fix this

@bcruddy
Copy link
Contributor Author

bcruddy commented May 10, 2017

That was quick, thank you!

@kulshekhar
Copy link
Owner

yeah, thanks to @thymikee here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants