Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to only using babel #358

Closed
GeeWee opened this issue Nov 2, 2017 · 5 comments
Closed

Switch to only using babel #358

GeeWee opened this issue Nov 2, 2017 · 5 comments

Comments

@GeeWee
Copy link
Collaborator

GeeWee commented Nov 2, 2017

Babel 7 is going to have typescript support https://github.com/babel/babylon/releases/tag/v7.0.0-beta.16

Combining this with jest having their own sourcemaps might make a large patch of our codebase obsolete, and simply replaceable with a .babelrc file. We should keep an eye on this.

@kulshekhar
Copy link
Owner

kulshekhar commented Nov 2, 2017

This is brilliant!

I think this will make ts-jest itself unnecessary. So maybe we don't really have to do anything :)

@GeeWee
Copy link
Collaborator Author

GeeWee commented Nov 2, 2017

Might be! I wouldn't mind that one bit!

@whitetrefoil
Copy link
Contributor

https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-typescript/README.md

According to Babel's doc, that plugin has some limitations like it cannot support namespaces, const enum, import =, export =...

I guess we still need ts-jest 😄

@kwonoj
Copy link
Contributor

kwonoj commented Jan 10, 2018

@whitetrefoil is correct, I gave a quick try on small repo I own and lot of TS-specific (i.e, exporting type like

type something = ...;
export {
something
}

syntax around won't work, and it's not supported scope from babel unfortunately.

@kulshekhar
Copy link
Owner

Thanks for letting us know @whitetrefoil @kwonoj

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants