-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to run TypeScript diagnostics #427
Conversation
586ed4d
to
e98f12f
Compare
e98f12f
to
17c2862
Compare
@alan-agius4 Thanks for taking the time to create the PR :) I just have one question - is ts-jest the right place for this? It sounds like something that should be done via an npm script using Also, should this discussion result in merging, all tests (currently failing) will need to pass. |
fb8706b
to
17c2862
Compare
By creating a `program` we are enabled to run diagnostics on typescipt files in order to emit semantic errors. For the time being I only used one of the many methods this one is `getPreEmitDiagnostics` This enables syntactic & semantic TypeScript error reporting
Test have been fixed. Well, as a matter of fact I actually did expect this was provided by I used |
I've actually resisted this feature for long but it seems more and more people want it. So I'm okay with this PR. @alan-agius4 Could you also:
|
Bumped and added myself to the authers |
One quick thing, shouldn't the bump be a |
yeah - we don't follow semver. We follow Jest's major version but beyond that it's a bit arbitrary. |
Merged and published. Thanks again for the PR @alan-agius4 😃 |
glad to help 😄 |
By creating a
program
we are enabled to run diagnostics on typescipt files in order to emit semantic errors. For the time being I only used one of the many methods this one isgetPreEmitDiagnostics
This enables syntactic & semantic TypeScript error reporting