Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "enableDiagnostics" option is broken in 22.4.0 #455

Closed
severen opened this issue Feb 26, 2018 · 4 comments · Fixed by #457 · May be fixed by baophucct/create-react-app-typescript#4
Closed

The "enableDiagnostics" option is broken in 22.4.0 #455

severen opened this issue Feb 26, 2018 · 4 comments · Fixed by #457 · May be fixed by baophucct/create-react-app-typescript#4

Comments

@severen
Copy link

severen commented Feb 26, 2018

In previous versions of ts-jest the enableDiagnostics option worked without issues. Starting with 22.4.0 it seems that some change in ts-jest's internal configuration has broken it.

I have confirmed with some local testing that disabling enableDiagnostics as is the default keeps ts-jest working.

A hopefully minimal enough repro and logs containing the relevant errors (check the Travis build error) can be found at this pull request on a project of mine.

@InExtremaRes
Copy link

Same here. This is the error message:

Option 'sourceMap' cannot be specified with option 'inlineSourceMap'

It seams like this line in the commit cb2d576 causes the issue.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Feb 28, 2018

I think either reverting back the change to bring delete config.sourceMap back or removing the line config.inlineSourceMap = true; in utils.js can solve the issue but I'm not sure about either of those ways.
cc @kulshekhar

@kulshekhar
Copy link
Owner

This is weird because it doesn't fail in tests. I'll take a closer look at this

@tipng
Copy link

tipng commented Mar 2, 2018

Hi, I'm facing the same issue here.

Is there a way to work around this for the time being?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment