Update types for FullJestConfig to be in sync with types in Jest #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulshekhar
reviewed
Mar 4, 2018
src/jest-types.ts
Outdated
| @@ -39,6 +39,10 @@ export interface FullJestConfig { | |||
| cacheDirectory: Path; | |||
| clearMocks: boolean; | |||
| coveragePathIgnorePatterns: string[]; | |||
| cwd: Path; | |||
| detectLeaks: boolean; | |||
| displayName: string; | |||
kulshekhar
reviewed
Mar 4, 2018
src/jest-types.ts
Outdated
| @@ -60,7 +60,7 @@ export interface FullJestConfig { | |||
| roots: Path[]; | |||
| runner: string; | |||
| setupFiles: Path[]; | |||
| setupTestFrameworkScriptFile: Path; | |||
| setupTestFrameworkScriptFile: Path | null; | |||
There was a problem hiding this comment.
This should originally have been setupTestFrameworkScriptFile?: Path;
There was a problem hiding this comment.
haha indeed it looks a bit confused to me when checking their types. If you look at their ProjectConfig type, it is ?Path but InitialOptions is setupTestFrameworkScriptFile?. I think we can just follow the ProjectConfig one to update similar to that
There was a problem hiding this comment.
oh right .. I guess I saw the other one. I think this should be fine :)
kulshekhar
approved these changes
Mar 4, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognize we have some missing types in FullJestConfig. This PR is to keep it in sync with types definition in Jest at https://github.com/facebook/jest/blob/master/types/Config.js