-
-
Notifications
You must be signed in to change notification settings - Fork 66
Migrate from jest to vitest #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from jest to vitest #92
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| export default defineConfig({ | ||
| test: { | ||
| globals: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only in @kuma-ui/babel-plugin, globals is set to true for babel-plugin-tester behavior.
|
@you-5805 While trying to run the changes locally, I encountered an error with the dependency Apart from that, I noticed you mentioned 'extract vitest config to workspace and reuse it (if needed)' in your TODO list. If it's possible to centralize the vitest configuration for reuse, that would be really appreciated. Once these changes are made, I believe your PR will be good to go. Thank you! |
|
@poteboy
The Vercel CI seems to be failing, but I'm unable to check the details🙏 |
poteboy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@you-5805
Thank you for your quick fixes!
No worries about the Vercel CI issue; it's due to an unrelated App Router cache problem that we're currently waiting on a Next.js fix for.
Everything else looks great! I appreciate your help with improving our test setup :)
Issue
#90
Overview
Migrate the test runner from jest to vitest
TODO
Comment