Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artist #133

Merged
merged 36 commits into from
Nov 19, 2018
Merged

Add artist #133

merged 36 commits into from
Nov 19, 2018

Conversation

kumabook
Copy link
Owner

No description provided.

@kumabook
Add migrations. Create tracks, albums and playlists from `enclo…
3691e90 
…sures` table
@kumabook
Add EnclosureConcern from Enclosure
fb3b130
@kumabook
Track and Album and Playlist don't inherit from Enclosure. Include En…
7fd0d8c 
…closureConcern instead
@kumabook
Liked|Saved|PlayedEnclosure has polymorphic association for tracks or…
a9d38be 
… albums or playlists. And they have each association for mix query
@kumabook
Disable Enclosure STI
16bdd28
@kumabook
Use unpack1
16810f6
@kumabook
EnclosureIssuesController follows enclosure table change
24b20c3
@kumabook
EnclosuresController follows enclosure table change
4d87163
@kumabook
Likable, Playable, Readable, Savable uses XXXEntry or XXXEnclosure
9432960
@kumabook
EnclosureEngagementScorer handles bind_values of sql correctly
2d7dbce
@kumabook
Pick is for relation between track and playlist
4dad2ad
@kumabook
Use self.arel_table instead of Enclosure.area_table
56b026a
@kumabook
EnclosureMark should joins different table (tracks, albums or playlis…
f369189 
…ts).

NOTE: `:enclosure` cannot be used due to ActiveRecord::EagerLoadPolymorphicError
@kumabook
Remove redundant has_many to enclosures
6418df7
@kumabook
Add divide_enclosures task
c383964
@kumabook
Add migration that creates artists and enclosure_artists tables
6d107c1
@kumabook
Implement Artist model class
5cd9518
@kumabook
Implement EnclosureArtist model class that is polymorphic association…
1f3f45a 
… between artist and track|album
@kumabook
Album and Track model has_many artists
5b98619
@kumabook
Add PinkSpider#fetch_artist, #fetch_artists
14047e9
@kumabook
Implement artist views and api
eeac035
@kumabook
Create track and album and playlist with pink_spider playlistify api …
e6e4ea1 
…response
@kumabook
Add fetch_artists rake task
0dab742
@kumabook
Create artist during handling playlistify api
41fa25a
@kumabook
Remove @content from Enclosure
a5083f9
@coveralls
Copy link

coveralls commented Nov 19, 2018 •
edited

Coverage Status

Coverage decreased (-0.3%) to 89.754% when pulling 63e9bc8 on add_artist into dc6c434 on master.

@kumabook kumabook merged commit a840d42 into master Nov 19, 2018
@kumabook kumabook deleted the add_artist branch November 19, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kumabook @coveralls