Skip to content

Commit

Permalink
fix: permadiff issue when docker_repository field is not specified
Browse files Browse the repository at this point in the history
relates to GoogleCloudPlatform/cloud-foundation-fabric#1987
When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
  • Loading branch information
kumadee committed Jan 21, 2024
1 parent 20a9ffe commit 163a7bc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions mmv1/products/cloudfunctions2/Function.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ properties:
name: 'dockerRepository'
description: |
User managed repository created in Artifact Registry optionally with a customer managed encryption key.
default_from_api: true
- !ruby/object:Api::Type::NestedObject
name: 'serviceConfig'
description: 'Describes the Service being deployed.'
Expand Down

0 comments on commit 163a7bc

Please sign in to comment.