Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*) cleanup of vuex store #209

Merged
merged 2 commits into from Aug 17, 2021

Conversation

tomaszwylezek
Copy link
Contributor

@tomaszwylezek tomaszwylezek commented Aug 17, 2021

Sumary

As we introduced mesh-insights some time ago, there is no longer a need to request for each policy/dataplanes etc. independently, as we can retrieve it from aggregated data.
Because of that, it allows us to remove a lot of code and simplify the logic.

Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek tomaszwylezek marked this pull request as ready for review August 17, 2021 13:28
@tomaszwylezek tomaszwylezek requested a review from a team as a code owner August 17, 2021 13:28
@tomaszwylezek tomaszwylezek changed the title refactor(*) initial cleanup of vuex store refactor(*) cleanup of vuex store Aug 17, 2021
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomaszwylezek tomaszwylezek merged commit 8446380 into kumahq:master Aug 17, 2021
@tomaszwylezek tomaszwylezek deleted the refactor/use-mesh-insights branch August 17, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants