feature(zones): adds Zone Instance Id and versioning information #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johncowen
commented
May 22, 2024
•
johncowen
commented
- Adds a Zone Instance Id to the title of the accordion bar, if this doesn't exist it will revert to use the GlobalControlPlanID as before.
- Adds ZoneCP version to the title of the accordion bar.
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
changed the title
johncowen
force-pushed
the
feature/zone-cp-improvements
branch
from
a688174
to
b508552
Compare
|
|
Signed-off-by: John Cowen <john.cowen@konghq.com>
johncowen
force-pushed
the
feature/zone-cp-improvements
branch
from
b508552
to
390db15
Compare
|
Ok so I am using the correct version, but we need to do this slightly differently depending on application. I'm gonna pull out the version notification thing so I can do it differently with that in mind, but leave the rest in so I can get this merged and move on/forward. |
Signed-off-by: John Cowen <john.cowen@konghq.com>
lahabana
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.