Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ensureDefaultXXX functions with a single generic function #2540

Closed
lobkovilya opened this issue Aug 10, 2021 · 2 comments · Fixed by #3662
Closed

Replace ensureDefaultXXX functions with a single generic function #2540

lobkovilya opened this issue Aug 10, 2021 · 2 comments · Fixed by #3662
Assignees
@tharun208
Labels
good first issue Good for newcomers kind/improvement Improvement on an existing feature triage/stale Inactive for some time. It will be triaged again

Comments

@lobkovilya
Copy link
Contributor

Summary

Today we have several similar functions:

  • ensureDefaultTrafficPermission
  • ensureDefaultTrafficRoute
  • ensureDefaultTimeout
  • ensureDefaultCircuitBreaker
  • ensureDefaultRetry
  • ...

They could be replaced with a single generic function, to avoid code duplications.

Based on #2507 (comment)
@lobkovilya lobkovilya mentioned this issue Aug 10, 2021
Merged
6 tasks
@jpeach jpeach added the good first issue Good for newcomers label Aug 10, 2021
@lahabana lahabana added kind/improvement Improvement on an existing feature and removed improvement labels Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 25, 2021
@tharun208
Copy link
Contributor

@lobkovilya I like to work on this

tharun208 added a commit to tharun208/kuma that referenced this issue Jan 7, 2022
@tharun208
refractor(*): replace ensureDefaultXXX functions with a single generi…
72afe1b 
…c function

Fixes kumahq#2540

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 mentioned this issue Jan 7, 2022
Merged
7 tasks
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 7, 2022
@tharun208
refactor(*): replace ensureDefaultXXX functions with a single generic…
a36ba74 
… function

Fixes kumahq#2540

Signed-off-by: Tharun <rajendrantharun@live.com>
lahabana pushed a commit that referenced this issue Jan 7, 2022
@tharun208
refactor(*): replace ensureDefaultXXX functions with a single generic…
2666c13 
… function (#3662)

Fixes #2540

Signed-off-by: Tharun <rajendrantharun@live.com>
@jpeach jpeach mentioned this issue Jan 10, 2022
Merged
6 tasks
jpeach added a commit that referenced this issue Jan 11, 2022
@jpeach
chore(kuma-cp): consolidate mesh defaults creation (#3678)
7491128 
Further consolidate the code that creates default mesh resources.

This updates #2540.

Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tharun208 tharun208

Labels
good first issue Good for newcomers kind/improvement Improvement on an existing feature triage/stale Inactive for some time. It will be triaged again
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(*): replace ensureDefaultXXX functions with a single generic function tharun208/kuma
4 participants
@jpeach @lahabana @lobkovilya @tharun208