Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to disable Insights #2565

Closed
lobkovilya opened this issue Aug 13, 2021 · 0 comments · Fixed by #3501
Closed

Remove ability to disable Insights #2565

lobkovilya opened this issue Aug 13, 2021 · 0 comments · Fixed by #3501
Assignees
@lahabana
Labels
area/kuma-cp kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

Summary

Today we have metrics.dataplane.enabled and metrics.zone.enabled options that allows to disable Insights. Taking into account #2526 (comment), probably makes sense to get rid of these options.

Additional Details & Logs

  • Version
  • Error logs
  • Configuration
  • Platform and Operating System
  • Installation Method (Helm, kumactl, AWS CloudFormation, etc.)
@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code area/kuma-cp triage/pending This issue will be looked at on the next triage meeting triage/accepted The issue was reviewed and is complete enough to start working on it and removed chore triage/pending This issue will be looked at on the next triage meeting labels Nov 22, 2021
@lahabana lahabana self-assigned this Dec 13, 2021
lahabana added a commit to lahabana/kuma that referenced this issue Dec 13, 2021
@lahabana
chore(config): remove ability to disable insights
6cce909 
remove `kuma.metrics.dataplane.enabled` and `kuma.metrics.zone.enabled`
as insights are required internally anyway.

Fix kumahq#2565

BREAKING CHANGE: it's now impossible to disable insights and the related configuration was removed

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Dec 13, 2021
Merged
2 tasks
lahabana added a commit that referenced this issue Dec 14, 2021
@lahabana
chore(config): remove ability to disable insights (#3501)
d76c44d 
remove `kuma.metrics.dataplane.enabled` and `kuma.metrics.zone.enabled`
as insights are required internally anyway.

Fix #2565

BREAKING CHANGE: it's now impossible to disable insights and the related configuration was removed

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
area/kuma-cp kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(config): remove ability to disable insights lahabana/kuma
2 participants
@lahabana @lobkovilya