Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/core shouldn't depend on kubernetes dependency #2798

Open
1 task
lahabana opened this issue Sep 20, 2021 · 14 comments
Open
1 task

pkg/core shouldn't depend on kubernetes dependency #2798

lahabana opened this issue Sep 20, 2021 · 14 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Sep 20, 2021 •
edited by michaelbeaumont

It currently depends on kubernetes for logging, uuid among other things. This should not be the case as this package is also used in kuma-dp and similar.

  • logging
@jpeach jpeach added the dependencies Pull requests that update a dependency file label Sep 20, 2021
@jpeach jpeach mentioned this issue Oct 4, 2021
Merged
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code and removed technical-debt labels Nov 22, 2021
@jpeach jpeach removed the triage/stale Inactive for some time. It will be triaged again label Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 24, 2021
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/stale Inactive for some time. It will be triaged again labels Jan 21, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 21, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 23, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 23, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 28, 2022
@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Jul 28, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@michaelbeaumont
Copy link
Contributor

I think this has gotten "worse" in the mean time. Maybe we need to reconsider the organization of pkg/core and move some things out of it?

@lahabana
Copy link
Contributor Author

lahabana commented May 2, 2023

Yeah I think more generally I'd be curious to see which transitive deps are being pulled in kuma-dp which shouldn't be.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka
Copy link
Contributor

slonka commented Feb 9, 2024

still the case

kuma/pkg/core/alias.go

Line 11 in 8b3a140

kube_log "sigs.k8s.io/controller-runtime/pkg/log"

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jpeach @lahabana @michaelbeaumont @slonka @jakubdyszkiewicz @bartsmykla @lukidzi