-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to deprecated protobuf lib #3499
Comments
I think the main blocker is the generated Envoy protobufs, envoyproxy/go-control-plane#524. |
This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This was introduced to support envoy < 1.20 which we no longer need to support xref #3499 Signed-off-by: Charly Molter <charly.molter@konghq.com>
This was introduced to support envoy < 1.20 which we no longer need to support xref #3499 --------- Signed-off-by: Charly Molter <charly.molter@konghq.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
Looks like there is one more place: https://github.com/kumahq/kuma/blob/master/pkg/plugins/policies/meshloadbalancingstrategy/plugin/xds/lbconfigurer.go#L5 |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
Hi ! |
What happened?
Kuma code imports
github.com/golang/protobuf/proto
in a number of places. This package is deprecated in favor ofgoogle.golang.org/protobuf/proto
. Should update everything to recommended package.Unfortunately, the two packages are not compatible, so need to update all dependencies of any changed module at the same time.
The text was updated successfully, but these errors were encountered: