Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support urlRewrite in MeshGatewayRoute #3908

Closed
lahabana opened this issue Feb 23, 2022 · 4 comments · Fixed by #4638
Closed

Support urlRewrite in MeshGatewayRoute #3908

lahabana opened this issue Feb 23, 2022 · 4 comments · Fixed by #4638
Labels
area/gateway Built-in Kuma gateway support kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

It's one of the most common use cases in gateways
GatewayAPI does it this way: https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.HTTPURLRewriteFilter
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it kind/feature New feature area/gateway Built-in Kuma gateway support labels Feb 23, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 26, 2022
@wjrbetts
Copy link
Contributor

We would really like to see this, specifically for removing a path prefix after matching on it.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Mar 28, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 28, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 15, 2022
@lahabana lahabana mentioned this issue Jun 15, 2022
Closed
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 16, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 18, 2022
@michaelbeaumont michaelbeaumont mentioned this issue Jul 19, 2022
Merged
michaelbeaumont added a commit that referenced this issue Jul 19, 2022
@michaelbeaumont
feat(gateway): support URL rewriting (#4638)
fe586e6 
Closes #4179, closes #3908

* feat(gateway): support URL rewriting
* test(e2e): enable experimental channel in tests
* test(e2e): add gatewy URL rewrite test
* chore(api): remove unused Messages
* refactor(gatewayapi): extract helper method
* test(e2e): fix path handling
* refactor(gateway): var naming
* feat(gateway): add validation for replacePrefixMatch

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gateway Built-in Kuma gateway support kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gateway): support URL rewriting michaelbeaumont/kuma
2 participants
@lahabana @wjrbetts