Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using deprecated serial numbers in token #4006

Closed
jakubdyszkiewicz opened this issue Mar 16, 2022 · 6 comments · Fixed by #5520
Closed

Warn when using deprecated serial numbers in token #4006

jakubdyszkiewicz opened this issue Mar 16, 2022 · 6 comments · Fixed by #5520
Assignees
@lahabana
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

Since 1.4 we rely on kid, not on serial number.

I don't think we did a good enough job recommending regeneration token, so it may not be feasible to remove it in the next version.
@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Mar 16, 2022
@lahabana
Copy link
Contributor

Triage: it's not that complex to maintain so let's keep it but let's just add a warning when using the old version

@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 21, 2022
@lahabana lahabana changed the title Remove deprecated serial numbers in token Warn when using deprecated serial numbers in token Mar 21, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 21, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Apr 21, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 22, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 23, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 23, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 27, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 28, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Jul 28, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Oct 27, 2022
@lahabana lahabana mentioned this issue Dec 19, 2022
Closed
lahabana added a commit to lahabana/kuma that referenced this issue Dec 19, 2022
@lahabana
fix: warn when using deprecated token id
3c7f028 
Tracking removal with kumahq#5519

Fix kumahq#4006

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Dec 19, 2022
Merged
11 tasks
@lahabana lahabana self-assigned this Dec 19, 2022
lahabana added a commit that referenced this issue Dec 19, 2022
@lahabana
fix: warn when using deprecated token id (#5520)
e42a3a2 
Tracking removal with #5519

Fix #4006

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: warn when using deprecated token id lahabana/kuma
3 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz