Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put coredns configuration in a configmap #8119

Closed
michaelbeaumont opened this issue Oct 24, 2023 · 5 comments
Closed

Put coredns configuration in a configmap #8119

michaelbeaumont opened this issue Oct 24, 2023 · 5 comments
Assignees
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@michaelbeaumont
Copy link
Contributor

Description

This would give users

  1. visibility
  2. configurability

into how we configure coredns to handle DNS requests in the mesh

@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Oct 24, 2023
@lahabana
Copy link
Contributor

Only question is universal. Having it embedded is nice for universal

@jakubdyszkiewicz
Copy link
Contributor

Triage: it's still useful to have this embedded in kuma-dp run

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Oct 30, 2023
@lahabana
Copy link
Contributor

lahabana commented Nov 6, 2023

xref: #8269

@jijiechen
Copy link
Member

Replacing #8633

More background:

Description

People want to customize the DNS template used by the kuma data plane to address following issues:

It's good to make our builtin Corefile template customizable.

It's best to support for both k8s and universal data planes.

Not in scope:

configuring command line of CoreDNS at data planes parameters from the control plane

@jijiechen
Copy link
Member

The PR has now been merged and we'll see if we need to backport to older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants