-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transparent-proxy): stop logging all to stderr when installing tproxy #10045
Merged
bartsmykla
merged 2 commits into
kumahq:master
from
bartsmykla:fix/stop-logging-all-to-stderr-when-installing-tproxy
Apr 23, 2024
Merged
fix(transparent-proxy): stop logging all to stderr when installing tproxy #10045
bartsmykla
merged 2 commits into
kumahq:master
from
bartsmykla:fix/stop-logging-all-to-stderr-when-installing-tproxy
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
requested review from
jijiechen and
lukidzi
and removed request for
a team
April 23, 2024 07:54
michaelbeaumont
approved these changes
Apr 23, 2024
Co-authored-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…roxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…roxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…roxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…roxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…roxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 23, 2024
…roxy (backport of #10045) (#10047) fix(transparent-proxy): stop logging all to stderr when installing tproxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 23, 2024
…roxy (backport of #10045) (#10048) fix(transparent-proxy): stop logging all to stderr when installing tproxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 23, 2024
…roxy (backport of #10045) (#10050) * fix(transparent-proxy): stop logging all to stderr when installing tproxy (#10045) Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr. Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the construction of the log line, where everything was located at the same line, we were not able to figure out at the beginnig of the log if it'll be successfull or not, so everything was logged in stderr. It's wrong when you have a monitoring set to watch stderr. I changed it so now the same information is placed in multiple lines and only failure is send to stderr.
Examples:
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSci/
labels to run additional/fewer testsUPGRADE.md
?