fix(gatewayapi): validate presence of all required Gateway API resources #10079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing check of presence for only `Gateway` resource is
insufficient in situation when some (not all) of the Gateway API
CRDs are missing (i.e. package with CRDs was installed before
`ReferenceGrant` was added), which causes CP to start throwing
lot of errors:
```
controller-runtime.source.EventHandler if kind is a CRD, it should
be installed before calling Start {"kind":
"ReferenceGrant.gateway.networking.k8s.io", "error": "no matches
for kind \"ReferenceGrant\" in version
\"gateway.networking.k8s.io/v1beta1\""}
```
This is the simplest solution as we could also verify if
`ReferenceGrant` is present, and if not to disable cross-mesh
references, but it would be unnecesarily complex, especially
in situation when Gateway API is GA and contains `ReferenceGrant`
in `v1`.
Signed-off-by: Bart Smykla <bartek@smykla.com>
|
can you make it to release 2.7? so instead of backport we will merge release to master? |
michaelbeaumont
approved these changes
Apr 25, 2024
bartsmykla
changed the title
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…ces (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…ces (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…ces (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…ces (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…ces (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 25, 2024
…ces (backport of #10079) (#10082) fix(gatewayapi): validate presence of all required Gateway API resources (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 25, 2024
…ces (backport of #10079) (#10083) * fix(gatewayapi): validate presence of all required Gateway API resources (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com> --------- Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 25, 2024
…ces (backport of #10079) (#10081) * fix(gatewayapi): validate presence of all required Gateway API resources (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com> --------- Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 25, 2024
…ces (backport of #10079) (#10084) * fix(gatewayapi): validate presence of all required Gateway API resources (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com> --------- Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added a commit
that referenced
this pull request
Apr 25, 2024
…ces (backport of #10079) (#10080) * fix(gatewayapi): validate presence of all required Gateway API resources (#10079) Existing check of presence for only `Gateway` resource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed before `ReferenceGrant` was added), which causes CP to start throwing lot of errors: ``` controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ReferenceGrant.gateway.networking.k8s.io", "error": "no matches for kind \"ReferenceGrant\" in version \"gateway.networking.k8s.io/v1beta1\""} ``` This is the simplest solution as we could also verify if `ReferenceGrant` is present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and contains `ReferenceGrant` in `v1`. Signed-off-by: Bart Smykla <bartek@smykla.com> --------- Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing check of presence for only
Gatewayresource is insufficient in situation when some (not all) of the Gateway API CRDs are missing (i.e. package with CRDs was installed beforeReferenceGrantwas added), which causes CP to start throwing lot of errors:This is the simplest solution as we could also verify if
ReferenceGrantis present, and if not to disable cross-mesh references, but it would be unnecesarily complex, especially in situation when Gateway API is GA and containsReferenceGrantinv1.Closes: #10074
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OSci/labels to run additional/fewer testsUPGRADE.md?