-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jobs): jobs termination after CP restart #10085
Merged
jakubdyszkiewicz
merged 1 commit into
kumahq:release-2.7
from
jakubdyszkiewicz:fix/jobs-termination
Apr 25, 2024
Merged
fix(jobs): jobs termination after CP restart #10085
jakubdyszkiewicz
merged 1 commit into
kumahq:release-2.7
from
jakubdyszkiewicz:fix/jobs-termination
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
requested review from
michaelbeaumont,
slonka and
lobkovilya
and removed request for
a team
April 25, 2024 13:17
lukidzi
approved these changes
Apr 25, 2024
backporting to release-2.3 with action |
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
This was referenced Apr 25, 2024
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Apr 25, 2024
jakubdyszkiewicz
added a commit
that referenced
this pull request
Apr 25, 2024
jakubdyszkiewicz
added a commit
that referenced
this pull request
Apr 25, 2024
jakubdyszkiewicz
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Fix jobs termination in case of CP missing update event (like CP restart etc.)
I tested it by applying this
then scaling CP down
then up
without this fix, the job stays running.
I'd love write E2E test for it, but it requires CP restart so it would land in non-env tests and it would be a time-consuming test.
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --