Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update go to 1.22.5 #10096

Merged
merged 5 commits into from
Jul 3, 2024
Merged

chore(deps): update go to 1.22.5 #10096

merged 5 commits into from
Jul 3, 2024

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Apr 26, 2024 •
edited by michaelbeaumont
Loading

Checklist prior to review

Update Go. Dependabot PRs are failing because it's trying to add toolchain directive and golangci-lint is missing file. I think we need to add this directive as well, but let's first upgrade Go.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz
chore(deps): update go to 1.22.2
f92a1ac 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 26, 2024 10:19
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen, slonka and lobkovilya and removed request for a team April 26, 2024 10:19
bartsmykla
bartsmykla previously requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do it for now:

@slonka
Copy link
Contributor

slonka commented Apr 29, 2024

We can't do it for now:

Should we put it in the comments in go.mod / CI config that we can't upgrade yet? I forgot about this and if Bart did not review I would've probably approved this.

This was referenced May 7, 2024
Closed
Closed
This was referenced Jun 5, 2024
Closed
Closed
Closed
Merged
@Automaat
Merge branch 'master' into update-go-1.22.2
0610174 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Copy link
Contributor

Automaat commented Jul 3, 2024

/format

@Automaat Automaat changed the title chore(deps): update go to 1.22.2 chore(deps): update go to 1.22.5 Jul 3, 2024
Icarus9913
Icarus9913 reviewed Jul 3, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@github-actions
fix(ci): format files
7223851 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@michaelbeaumont
Revert "fix(ci): format files"
6d46bb8 
This reverts commit 7223851.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: remove blank line
b1972db 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 3, 2024 06:57
@michaelbeaumont michaelbeaumont merged commit 2c65968 into kumahq:master Jul 3, 2024
20 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

backporting to release-2.6 with action

backporting to release-2.4 with action
backporting to release-2.8 with action
backporting to release-2.7 with action

kumahq bot pushed a commit that referenced this pull request Jul 10, 2024
@jakubdyszkiewicz @Automaat
@github-actions @michaelbeaumont @kumahq
chore(deps): update go to 1.22.5 (#10096)
28c6a3e 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Jul 10, 2024
Merged
kumahq bot pushed a commit that referenced this pull request Jul 10, 2024
@jakubdyszkiewicz @Automaat
@github-actions @michaelbeaumont @kumahq
chore(deps): update go to 1.22.5 (#10096)
51cde6d 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Jul 10, 2024
@jakubdyszkiewicz @Automaat
@github-actions @michaelbeaumont @kumahq
chore(deps): update go to 1.22.5 (#10096)
d050207 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jul 10, 2024
Open
Open
kumahq bot pushed a commit that referenced this pull request Jul 10, 2024
@jakubdyszkiewicz @Automaat
@github-actions @michaelbeaumont @kumahq
chore(deps): update go to 1.22.5 (#10096)
85761e8 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Jul 10, 2024
Merged
kumahq bot pushed a commit that referenced this pull request Jul 10, 2024
@jakubdyszkiewicz @Automaat
@github-actions @michaelbeaumont @kumahq
chore(deps): update go to 1.22.5 (#10096)
475a3cd 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Jul 10, 2024
Merged
slonka pushed a commit that referenced this pull request Jul 10, 2024
@kumahq @jakubdyszkiewicz
@Automaat @github-actions @michaelbeaumont
chore(deps): update go to 1.22.5 (backport of #10096) (#10853)
b75549d 
chore(deps): update go to 1.22.5 (#10096)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 10, 2024
@kumahq @jakubdyszkiewicz
@Automaat @github-actions @michaelbeaumont
chore(deps): update go to 1.22.5 (backport of #10096) (#10857)
7156631 
chore(deps): update go to 1.22.5 (#10096)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
slonka pushed a commit that referenced this pull request Jul 10, 2024
@kumahq @jakubdyszkiewicz
@Automaat @github-actions @michaelbeaumont
chore(deps): update go to 1.22.5 (backport of #10096) (#10856)
9b6b49c 
chore(deps): update go to 1.22.5 (#10096)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@Icarus9913 Icarus9913 Icarus9913 left review comments

@Automaat Automaat Automaat approved these changes

@bartsmykla bartsmykla bartsmykla left review comments

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jakubdyszkiewicz @slonka @Automaat @michaelbeaumont @bartsmykla @Icarus9913