Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): use EndpointSlices to determine identity for Service without selectors #10134

Merged
merged 9 commits into from
May 23, 2024
Merged

fix(k8s): use EndpointSlices to determine identity for Service without selectors #10134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4bdcfcd
fix(k8s): use EndpointSlices to determine Service endpoints
michaelbeaumont Apr 29, 2024
e857a38
test(k8s): update test
michaelbeaumont Apr 29, 2024
42e17ae
test(kumactl): update golden files
michaelbeaumont Apr 30, 2024
65ffa23
refactor: skip reconciling Pods via EndpointSlice if we reconcile anyway
michaelbeaumont May 7, 2024
090a373
fix: just continue if we can't find the service instead of queueing a…
michaelbeaumont May 8, 2024
656780c
Update pkg/plugins/runtime/k8s/util/util_test.go
michaelbeaumont May 8, 2024
b4696a8
test(k8s): add test for Services without selectors
michaelbeaumont May 9, 2024
62b18a0
chore: fixed up logging
michaelbeaumont May 14, 2024
03672a1
Merge branch 'master' into fix/use-endpoints
michaelbeaumont May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7995,6 +7995,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7995,6 +7995,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.registry.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions ...l/cmd/install/testdata/install-control-plane.tproxy-ebpf-experimental-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8015,6 +8015,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/doNotChangeTlsChecksum.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/empty.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix4485.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix4496.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix4935.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix5978.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix7724.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/fix7824.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/minReadySeconds.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/securityContext.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
8 changes: 8 additions & 0 deletions deployments/charts/kuma/templates/cp-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,14 @@ rules:
- create
- update
- patch
- apiGroups:
- "discovery.k8s.io"
resources:
- endpointslices
verbs:
- get
- list
- watch
- apiGroups:
- kuma.io
resources:
Expand Down
Loading
Loading