feat(kuma-cp) central place for creating defaults #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
Sep 14, 2020
nickolaev
approved these changes
Sep 14, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Sep 15, 2020
nickolaev
pushed a commit
that referenced
this pull request
Oct 1, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kuma-cp/cmd/run.go # pkg/core/bootstrap/bootstrap.go # pkg/tokens/builtin/issuer/signing_key.go Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
pushed a commit
that referenced
this pull request
Oct 1, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kuma-cp/cmd/run.go # pkg/core/bootstrap/bootstrap.go # pkg/tokens/builtin/issuer/signing_key.go
nickolaev
pushed a commit
that referenced
this pull request
Oct 5, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kuma-cp/cmd/run.go # pkg/core/bootstrap/bootstrap.go # pkg/tokens/builtin/issuer/signing_key.go
nickolaev
pushed a commit
that referenced
this pull request
Oct 5, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kuma-cp/cmd/run.go # pkg/core/bootstrap/bootstrap.go # pkg/tokens/builtin/issuer/signing_key.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since on the horizon, I see creating default TrafficPermission / TrafficRoute I created a module for creating default values. For now we create there Mesh and Signing Key for Dataplane Tokens.
Previously we were creating a Mesh using Namespace Reconciller. Now there is a central place for creating defaults for both K8S and Universal.
I added retries for the Mesh #882 so on Kubernetes we won't see initial errors (visible only on Debug level).
Issues resolved
Fix #882
Documentation