Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): filter out old dangling zone resources in global #10245

Merged
merged 2 commits into from
May 16, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 16, 2024

Now if there are <zone-name>-prefixes added to hashed versions (which can be reproduced as described below), they are removed initially and later resynced if the zone sends them again.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • single zone:
      1. zone CP upgrade 2.6.2
      2. global CP upgrade 2.6.2
      3. see dangling resources
      4. dangling resources still there
      5. global CP upgrade this fix
      6. resources gone
    • multizone:
      1. west CP upgrade 2.6.2
      2. global CP upgrade 2.6.2
      3. dangling resources from west in global and east
      4. east CP upgrade 2.6.2
      5. global CP upgrade this fix
      6. resources gone from global and zones
    • multizone:
      1. west CP upgrade 2.6.2
      2. east CP upgrade 2.6.2
      3. global CP upgrade 2.6.2
      4. dangling resources from both west and east in global and east/west
      5. global CP upgrade this fix
      6. resources gone from global and zones
    • new ZoneIngresses come up fine after this change
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner May 16, 2024 10:14
@michaelbeaumont michaelbeaumont requested review from jijiechen, Automaat and bartsmykla and removed request for a team May 16, 2024 10:14
@michaelbeaumont michaelbeaumont changed the base branch from release-2.6 to release-2.7 May 16, 2024 12:27
@michaelbeaumont michaelbeaumont changed the base branch from release-2.7 to release-2.6 May 16, 2024 12:29
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label May 16, 2024
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the title fix(kuma-cp): filter out dangling zone resources in global fix(kuma-cp): filter out old dangling zone resources in global May 16, 2024
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 590d02c into kumahq:release-2.6 May 16, 2024
31 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/kds-zone-sync branch May 16, 2024 15:27
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request May 17, 2024
…ort of kumahq#10245)

Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request May 17, 2024
…ort of #10245) (#10268)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Ilya Lobkov <lobkovilya@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) release-2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants