fix(*) drop k8s 1.13 support #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 17, 2020 10:13
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.14.md#deprecations `OS and Arch information is now recorded in kubernetes.io/os and kubernetes.io/arch labels on Node objects. The previous labels (beta.kubernetes.io/os and beta.kubernetes.io/arch) are still recorded, but are deprecated and targeted for removal in v1.18.` Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable testing against Kubernetes 1.13.
#990 introduces NodeSelectors for CP and CNI pods in the Helm Charts. #989 makes the Helm Charts the default installation templating for
kumactl install control-plane.Kubernetes 1.14 introduces
kubernetes.io/osandkubernetes.io/archand deprecatesbeta.kubernetes.io/osandbeta.kubernetes.io/arch. This effectively makes Kuma Helm Charts and nowkumactl install control-planeunusable on Kubernetes versions prior to 1.14, as the deployment hangs trying to find nodes labelled withkubernetes.io/osandkubernetes.io/arch, while such does not exist (as 1.13 uses thebetalabels).As the
betalabels are not supported at all since 1.18, we'd better drop 1.13 support here.While we are here, fix also:
Issues resolved
Master CI is failing
Documentation