Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshService): handle headless Services #10308

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 23, 2024

Part of #10071

Needs:

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the feat/ms-headless branch 4 times, most recently from 610f11e to 0518bb3 Compare May 27, 2024 11:30
@michaelbeaumont michaelbeaumont marked this pull request as ready for review May 27, 2024 12:13
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner May 27, 2024 12:13
@michaelbeaumont michaelbeaumont requested review from jijiechen, jakubdyszkiewicz and lukidzi and removed request for a team May 27, 2024 12:13
@michaelbeaumont michaelbeaumont force-pushed the feat/ms-headless branch 3 times, most recently from 79be266 to 13cc9e7 Compare May 27, 2024 13:53
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…th too long a name

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…bout length

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 28, 2024 19:39
@michaelbeaumont michaelbeaumont merged commit 8567857 into kumahq:master Jun 4, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/ms-headless branch June 4, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement remainder of MeshService Kubernetes UX MADR
2 participants