Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshService): handle headless Services #10308

Merged
merged 11 commits into from
Jun 4, 2024
Merged

feat(MeshService): handle headless Services #10308

merged 11 commits into from
Jun 4, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 23, 2024 •
edited

Part of #10071

Needs:

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the feat/ms-headless branch 4 times, most recently from 610f11e to 0518bb3 Compare May 27, 2024 11:30
@michaelbeaumont michaelbeaumont marked this pull request as ready for review May 27, 2024 12:13
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner May 27, 2024 12:13
@michaelbeaumont michaelbeaumont requested review from jijiechen, jakubdyszkiewicz and lukidzi and removed request for a team May 27, 2024 12:13
@michaelbeaumont michaelbeaumont force-pushed the feat/ms-headless branch 3 times, most recently from 79be266 to 13cc9e7 Compare May 27, 2024 13:53
@michaelbeaumont
feat(MeshService): handle headless Services
ef248bb 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: fix variable typo
f76d011 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: fix RBAC
3f98a99 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshService): add headless Service test
946156c 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge branch 'master' into feat/ms-headless
3e6b6e9 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: remove unused code
5f832bc 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshService): add endpoint to headless service case
2627cbc 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix(MeshService): ensure that we don't try to create a MeshService wi…
b41cee7 
…th too long a name

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: update golden
283aae3 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: Pod names are 63 characters max so we don't need to worry a…
1ab2e76 
…bout length

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: check whether owner is a Pod
fbc6be2 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) May 28, 2024 19:39
@michaelbeaumont michaelbeaumont mentioned this pull request Jun 3, 2024
Closed
@michaelbeaumont michaelbeaumont linked an issue Jun 3, 2024 that may be closed by this pull request
Implement remainder of MeshService Kubernetes UX MADR #10071
Closed
@michaelbeaumont michaelbeaumont merged commit 8567857 into kumahq:master Jun 4, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/ms-headless branch June 4, 2024 10:50
@BrewTestBot BrewTestBot mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement remainder of MeshService Kubernetes UX MADR
2 participants
@michaelbeaumont @jakubdyszkiewicz