Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-dp): add function to find default CA #10367

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jun 3, 2024

xrel: #10238

Checklist prior to review

I added an option to propagate information about the default OS CA certificate in a bootstrap request from kuma-dp.

  • a user can provide a path to the certificate when it's not a default one for the OS
  • if the cert path is not provided we are scanning default paths based on the https://golang.org/src/crypto/x509/root_linux.go
  • propagate the information in metadata
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review June 3, 2024 12:07
@lukidzi lukidzi requested a review from a team as a code owner June 3, 2024 12:07
@lukidzi lukidzi requested review from slonka, jakubdyszkiewicz and lobkovilya and removed request for a team June 3, 2024 12:07
@lukidzi lukidzi merged commit cc25719 into kumahq:master Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants