-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp): validate the bandwidth strictly #10371
Conversation
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
The test failed because unit
But according to the code in kuma/pkg/xds/envoy/listeners/v3/util.go Lines 123 to 134 in 536ea8c
The unit should be case-sensitive. Which one needs to be changed? |
the test in
according to https://en.wikipedia.org/wiki/Metric_prefix |
So 100mbps means mill-bps. I will vote for changing the test as Envoy itself does not support this unit. |
you can just change it |
@slonka |
Signed-off-by: Krzysztof Słonka <slonka@users.noreply.github.com>
Need to fix the examples as well https://kuma.io/docs/2.7.x/policies/meshfaultinjection/#configuration |
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --