feat(kumactl) merge install ingress into install control-plane

[austince]

Summary

Merge and remove the kumactl install ingress command into the kumactl install control-plane

Full changelog

• Implement merging the current install ingress flags into the install control-plane command, under the --ingress prefix
• Removes the install ingress command
• Fix mapping of the repository args

Issues resolved

Fix #1020

Documentation

• Link to the website documentation PR docs(*) merge install ingress into install control-plane kuma-website#284

[austince]

One question I had during implementation, which applies to both this command and the Helm chart, is: how would a user deploy multiple ingresses to different meshes? Would they need multiple control planes? This seems like a reason to perhaps split the Helm chart or allow multiple ingresses to be installed at once.

[jakubdyszkiewicz]

If you are talking about Kuma Ingress for cross-cluster communication then it works regardless of the mesh, so you can have many Meshes in your CP and one Ingress.

[austince]

If you are talking about Kuma Ingress for cross-cluster communication then it works regardless of the mesh, so you can have many Meshes in your CP and one Ingress.

Got it, thanks. The current Ingress Deployment in the chart specifies a kuma.io/mesh: default-or-user-defined annotation for the pods -- is this still the same functionality?

[lobkovilya]

Hey @austince! Ideally, we would like to get rid of Mesh field when it comes to Ingress resources. But now we don't have such concept as a non-mesh scoped resources, so all resources right now belong to some mesh. It's actually the same issue that we have for Zones - #1023.

Answering your question - yes, it is the same functionality even if the user provides some specific value for kuma.io/mesh. Kuma CP anyway looks through all meshes to generate Ingress resource.

[austince]

Cool, thanks for the explanation Ilya!

[austince]

Looks like just a failing e2e test, but I think ready for review :)

[jakubdyszkiewicz]

I'm fixing the flakiness of e2e in a separate PR.