feat(kuma-cp) exclude traffic interceptions on port using annotations #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Oct 2, 2020
lobkovilya
approved these changes
Oct 2, 2020
nickolaev
pushed a commit
that referenced
this pull request
Oct 2, 2020
…#1046) Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kumactl/cmd/completion/testdata/bash.golden # app/kumactl/cmd/completion/testdata/zsh.golden # app/kumactl/cmd/install/install_control_plane.go # app/kumactl/cmd/install/render_helm_files.go # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go # deployments/charts/kuma/README.md # deployments/charts/kuma/templates/cp-deployment.yaml # deployments/charts/kuma/values.yaml # docs/cmd/kumactl/HELP.md # pkg/api-server/config_ws_test.go # pkg/config/app/kuma-cp/kuma-cp.defaults.yaml # pkg/config/loader_test.go # pkg/config/plugins/runtime/k8s/config.go # pkg/plugins/runtime/k8s/controllers/namespace_controller_test.go # pkg/plugins/runtime/k8s/metadata/annotations.go # pkg/plugins/runtime/k8s/webhooks/injector/injector.go # pkg/plugins/runtime/k8s/webhooks/injector/injector_test.go # pkg/plugins/runtime/k8s/webhooks/injector/testdata/inject.14.golden.yaml # pkg/plugins/runtime/k8s/webhooks/injector/testdata/inject.15.golden.yaml # pkg/plugins/runtime/k8s/webhooks/injector/testdata/inject.16.golden.yaml Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
pushed a commit
that referenced
this pull request
Oct 5, 2020
…#1046) Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
pushed a commit
that referenced
this pull request
Oct 5, 2020
…#1046) Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces annotations to exclude specified ports from being intercepted by Envoy
Additionally, there is an option to apply this globally with
Because overriding individual config settings was not possible on K8S I introduced
in HELM
and
in
kumactl installWhen you apply global configuration, we automatically add annotation to Pod but only if the annotation is not defined, so the user can override global behavior.
Documentation