Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build) use make param to start kube clusters for e2e tests #1064

Merged
merged 2 commits into from
Oct 12, 2020
Merged

chore(build) use make param to start kube clusters for e2e tests #1064

merged 2 commits into from
Oct 12, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Use $(MAKE) instead of make so we can use make -j test/e2e, this way K8S clusters are run in parallel.

@jakubdyszkiewicz
chore(build) use make to start kube clusters for e2e tests
fe479e7 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 12, 2020 11:53
nickolaev
nickolaev approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also update the other places: check.mk, kind.mk and test.mk?

@jakubdyszkiewicz
parametrize other makefile parts
a13d6b6 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@nickolaev
Copy link
Contributor

Great, let's merge this one.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 577fe57 into master Oct 12, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/e2e-make-param branch October 12, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @nickolaev