Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): fix conn closed error on transaction rollback #10665

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Jun 27, 2024

We were observing conn closed errors on transaction rollback when context was cancelled. I've found in pgx issues that if context is cancelled pgx will close the connection. So we should not run Rollback as it will end up in errors. pgx issue link. When connection is closed, Postgres will automatically rollback the transaction

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner June 27, 2024 14:17
@Automaat Automaat requested review from michaelbeaumont and slonka and removed request for a team June 27, 2024 14:17
@Automaat Automaat merged commit 3503ad1 into kumahq:master Jun 28, 2024
21 checks passed
@Automaat Automaat deleted the fix/conn-closed-on-rolback branch June 28, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants