Feature/dataplane inspection konvoyctl new #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/dataplane-inspection-konvoyctl-new
branch
from
39b9a71
to
a25b69c
Compare
yskopets
suggested changes
Aug 19, 2019
components/konvoy-control-plane/app/konvoyctl/pkg/cmd/root_context.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/core/resources/apis/mesh/dataplane_inspection_test.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/discovery/v1alpha1/discovery.pb.validate.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/api-server/dataplane_inspection_ws_test.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/api-server/dataplane_inspection_ws_test.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/api-server/dataplane_inspection_ws.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/core/resources/apis/mesh/dataplane_inspection.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/core/resources/model/rest/unmarshalling.go
Outdated
Show resolved
Hide resolved
jakubdyszkiewicz
force-pushed
the
feature/dataplane-inspection-konvoyctl-new
branch
from
796d864
to
22e713d
Compare
jakubdyszkiewicz
force-pushed
the
feature/dataplane-inspection-konvoyctl-new
branch
from
22e713d
to
cb0c3c4
Compare
yskopets
reviewed
Aug 21, 2019
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/app/konvoyctl/cmd/get/get_dataplanes.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/app/konvoyctl/cmd/get/get_dataplanes.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/pkg/api-server/dataplane_overview_ws.go
Outdated
Show resolved
Hide resolved
yskopets
reviewed
Aug 22, 2019
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/api/mesh/v1alpha1/dataplane_helpers_test.go
Show resolved
Hide resolved
components/konvoy-control-plane/app/konvoyctl/cmd/inspect/inspect_dataplanes.go
Outdated
Show resolved
Hide resolved
components/konvoy-control-plane/app/konvoyctl/cmd/inspect/inspect_dataplanes.go
Outdated
Show resolved
Hide resolved
yskopets
approved these changes
Aug 22, 2019
jakubdyszkiewicz
force-pushed
the
feature/dataplane-inspection-konvoyctl-new
branch
from
112829a
to
0f0b7c3
Compare
jakubdyszkiewicz
force-pushed
the
feature/dataplane-inspection-konvoyctl-new
branch
from
0f0b7c3
to
5c72464
Compare
jakubdyszkiewicz
deleted the
feature/dataplane-inspection-konvoyctl-new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow
make generategenerated some validation Protobuf files for existing files.New core entity includes dataplane and dataplane insights and it results in dataplane inspection. New endpoint is
/mesh/{mesh}/dataplane-inspections.Sorry about the PR size.