feat(kuma-cp) store VIP per Mesh

[lobkovilya]

Summary

This PR allows getting rid of inefficient DataplaneToSameMeshDataplanesMapper and replace it with watcher of VIP state at the current Mesh.

Documentation

• Link to the website documentation PR

[nickolaev]

Interesting, why is this?

[jakubdyszkiewicz]

Have you tested this with multicluster? I think this should be only created on the remote and standalone.

[jakubdyszkiewicz]

And this would actually work great with the defaults/mesh

[lobkovilya]

Deleted logic from this place, now Persistence.Set create or update config:

func (m *Persistence) Set(mesh string, vips List) error {
	ctx := context.Background()
	name := fmt.Sprintf(template, mesh)
	resource := &config_model.ConfigResource{}
	create := false
	if err := m.configManager.Get(ctx, resource, store.GetByKey(name, model.NoMesh)); err != nil {
		if !store.IsResourceNotFound(err) {
			return err
		}
		create = true
	}

	jsonBytes, err := json.Marshal(vips)
	if err != nil {
		return errors.Wrap(err, "unable to marshall VIP list")
	}
	resource.Spec.Config = string(jsonBytes)

	if create {
		meshRes := &mesh_core.MeshResource{}
		if err := m.resourceManager.Get(ctx, meshRes, store.GetByKey(mesh, model.NoMesh)); err != nil {
			return err
		}
		return m.configManager.Create(ctx, resource, store.CreateByKey(name, model.NoMesh), store.CreateWithOwner(meshRes))
	} else {
		return m.configManager.Update(ctx, resource)
	}
}

to be the same for Universal and Kubernetes

[jakubdyszkiewicz]

Is it now the same with Universal? Can we moved it back to components?

[jakubdyszkiewicz]

Ok, I see why this is a case. I think it's not a good idea to carry all the internals of DNS to the reconciler. What you really want to do is to Instruct VipAllocator to do the update on the mesh X. So my proposal is

1. Include VipAllocator into Runtime
2. Instead of having

func CreateOrUpdateVIPConfig(p *MeshedPersistence, rm manager.ReadOnlyResourceManager, r DNSResolver, ipam IPAM, mesh string) error {

This should be

func (d *vipsAllocator) CreateOrUpdateVIPConfig(mesh string) error {

3. Pass VIP allocator to this reconciller and execute this method
4. Move back all DNS component preparation into common components

[lobkovilya]

I didn't want to put VipAllocator into Runtime. I made it stateless and dependent only on runtime components, so now it's easy to create it from any place:

vipsAllocator, err := dns.NewVIPsAllocator(
	rt.ReadOnlyResourceManager(),
	rt.ConfigManager(),
	rt.Config().DNSServer.CIDR,
	rt.DNSResolver(),
)

[jakubdyszkiewicz]

do we need global at all?

[lobkovilya]

Yes, we need it to have the same VIP for services across Meshes